Code Reviews

Code Review Checklist

Code reviews are a very important part of the development process, in any environment. It is another safety net in ensuring a software deliverable of high quality. These are some points to keep in mind about code reviews. Take note of what needs to happen before, during and after a code review:
  1. Make sure that your code is self-explanatory and has adequate amount of code documentation and comments. These comments needs to describe the problem it is addressing in a clear and concise manner.
  2. Automated tests are good to test chunks of functionality. Include automated tests with your changes to make it easier to validate that your code works. In a SQL heavy environment, calling the different SP with specific input parameter values and inspecting the return result, or db stored result is a good midway point in testing the code.
  3. Your code should be sitting in source control.
  4. Before a code review commences:
    1. Set a date and time for the review to commence, and send out a meeting request - keep things professional.
    2. Have the IFS (i.e. other technical specification and business specification documents ready)
    3. Have test data ready to be processed by your code.
    4. Have sample input data ready to be processed by your code.
    5. Provide an overview of the problem statement to the code reviewer so that he/she understand what it is that your code is about
  5.  As the code review commences:
    1. Create a checklist of project-specific and programming language-specific things that you need to check during code reviews and use it for all reviews.
    2. Compare structural differences between what was previously in source control to the latest changes in source control
    3. Make sure that the fix or feature that the branch implements actually works (duh!).
  6. After the code review iteration is complete
    1. After the code review has successfully completed, ensure that the changeset (or tag) that has been approved is pushed to the QA environment for further integration testing.
The important thing to remember about code reviews is: if its your code being reviewed, you need to demonstrate your mastery on understanding the problem, and clearly communicating your knowledge of the problem over to the code reviewer.

Happy code reviewing :)

www.silvafox.co.za

Comments

Post a Comment

Popular posts from this blog

"Bigness" data - some thoughts about the big data journey

The " Bigness " data. Ideas of Big Data If you are reading this blog, you are likely to be a nerd. Everywhere - Yes, data is everywhere, and the volumes are exponentially increasing by day. There exists a saying: "Where there is a will there is relatives". Are your measures trustworthy? Ensure their integrity, but at the same time give attention to the training needed to its users. Data Detectives - The cool part for me of data science, is the detecting fraud part. Fraudsters love lots and lots of data. The more the merrier. Its also easier to hide abnormalities when lots of data are present. Therefore, if you find your organization at the stage where you are IYO consuming and processing big data, then its time you consider employing a data detective. Machine Learning - This will only be useful if you actually start using what your system is learning about trends, etc OODA Loop - What came first? The egg or the chicken. This scenario gives ri
Read more

Moving Data [Apache Spark]

So I decided I'm going to use a real world example and do some transformations against such. I decided on http://dumps.wikimedia.org , so that I have some nice sized files which I'm able to really see the advantages Apache Spark brings to the table. My system is loaded with Apache Spark 1.6.0 and Scala 2.10.5. Lets do this : First open the spark shell: spark-shell Next load an SQLContext: val sqlContext = new org.apache.spark.sql.SQLContext(sc) //sc an existing Spark context  Next import the following packages into the shell session: import sqlContext.implicits._ import org.apache.spark.sql._ Now, you can start by loading the data from the " pagecounts-2011222 " file into a Resilient Distributed Dataset (RDD). RDDs have transformations and actions; the first() action returns the first element in the RDD  Now load the data from the file into a new RDD: val wikiHits = sc.textFile("/home/osboxes/Downloads/pagecounts-20151222") Do some
Read more